Open
Conversation
ajoykumardas12
left a comment
ajoykumardas12
left a comment
There was a problem hiding this comment.
Reviewed with mostly JS knowledge and little Vue knowledge 😅
Also, any visuals for changes?
Comment on lines
+42
to
+48
| user, | ||
| token, | ||
| setToken, | ||
| setUser, | ||
| signin, | ||
| signout, | ||
| isLoading, |
There was a problem hiding this comment.
Should token, setToken, setUser be exported? Or they are exported for tests?
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch. Will address it.
Comment on lines
+55
to
+61
| const LINKS = [ | ||
| { name: 'Welcome', link: 'https://welcome.realdevsquad.com' }, | ||
| { name: 'Events', link: 'https://www.realdevsquad.com/events.html' }, | ||
| { name: 'Members', link: 'https://members.realdevsquad.com/' }, | ||
| { name: 'Crypto', link: 'https://crypto.realdevsquad.com/' }, | ||
| { name: 'Status', link: 'https://status.realdevsquad.com/' } | ||
| ] |
There was a problem hiding this comment.
These constants can be moved to constants file.
| throw error // or Log here | ||
| }) | ||
| .then(res => transformSelfInfoFromApi(res.data)) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
#191
Description:
Anything you would like to inform the reviewer about:
Dev Tested:
Put the Feature behind Feature Flag
Test Stats
Images/video of the change:
Follow-up Issues (if any):